MensBeam/Arsse

Work around brittle timestamp comparisons in tests #112

New issue

Closed

opened 2017-09-29 13:49:05 -04:00 by jking · 0 comments

jking commented

2017-09-29 13:49:05 -04:00

Owner

Feed and database tests can sometimes fail because timestamps being compared against expectations are off by one second. I'm not certain how this can be worked around for PHPUnit database tests (see issue #111), but for non-database tests, we can and should fudge the date: second precision is not required for any tests, and likely will never be.

Feed and database tests can sometimes fail because timestamps being compared against expectations are off by one second. I'm not certain how this can be worked around for PHPUnit database tests (see issue #111), but for non-database tests, we can and should fudge the date: second precision is not required for any tests, and likely will never be.

jking added this to the Future milestone

2017-09-29 13:49:05 -04:00

jking added the

labels

2017-09-29 13:49:05 -04:00

jking referenced this issue from a commit

2017-12-08 16:00:37 -05:00

Munge off-by-one dates in tests; fixes #112

jking closed this issue

2017-12-08 16:00:37 -05:00

jking modified the milestone from Future to 0.3.0

2018-01-01 09:38:46 -05:00

Sign in to join this conversation.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

-

Dependencies

No dependencies set.

Reference: MensBeam/Arsse#112

No description provided.