Labels Milestones

New Issue

User class should not depend on Database class when driver implements internal methods #38

Closed

opened 7 years ago by jking · 2 comments

jking commented 7 years ago

Owner

The User class incorrectly interfaces directly with the Database class even when the driver reports implementing a method internally. This occurs with e.g. the exists() method; conseqently the first test in e6feb8de8d is wrong and the whole series needs to be fixed by not creating $this->data->db.

The User class incorrectly interfaces directly with the Database class even when the driver reports implementing a method internally. This occurs with e.g. the exists() method; conseqently the first test in e6feb8de8dc9b0c2f4357e9a60920e1de9b6b0b2 is wrong and the whole series needs to be fixed by not creating $this->data->db.

jking commented 7 years ago

Poster

Owner

This should be fixed by commit 7785eb072b, but there may still be bugs; test coverage needs to improve before this issue can be closed.

This should be fixed by commit 7785eb072ba927aa1ccc8d63425fef3b479e4cc2, but there may still be bugs; test coverage needs to improve before this issue can be closed.

jking commented 7 years ago

Poster

Owner

Confirmed fixed by commit 1834cb9963.

Confirmed fixed by commit 1834cb9963262cb164ff3f9d252fdf12d7dcfa51.

jking closed this issue 7 years ago

jking added this to the 0.1.0 milestone 7 years ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

arch

arch2

dbtest

getopt

master

microsub

phake

reader

redup

rpm

0.1.0

0.1.1

0.10.0

0.10.1

0.10.2

0.10.3

0.10.4

0.10.5

0.2.0

0.2.1

0.3.0

0.3.1

0.4.0

0.5.0

0.5.1

0.6.0

0.6.1

0.7.0

0.7.1

0.8.0

0.8.1

0.8.2

0.8.3

0.8.4

0.8.5

0.9.0

0.9.1

0.9.2

Labels

Apply labels

Clear labels

admin tools api bug documentation duplicate enhancement feature help wanted in progress internals invalid packaging question testing trivial wontfix

No Label admin tools api bug documentation duplicate enhancement feature help wanted in progress internals invalid packaging question testing trivial wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

0.1.0

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.