User class should not depend on Database class when driver implements internal methods #38

New issue

Closed

opened 2017-02-19 00:40:50 -05:00 by jking · 2 comments

jking commented

2017-02-19 00:40:50 -05:00

Owner

The User class incorrectly interfaces directly with the Database class even when the driver reports implementing a method internally. This occurs with e.g. the exists() method; conseqently the first test in e6feb8de8d is wrong and the whole series needs to be fixed by not creating $this->data->db.

The User class incorrectly interfaces directly with the Database class even when the driver reports implementing a method internally. This occurs with e.g. the exists() method; conseqently the first test in e6feb8de8dc9b0c2f4357e9a60920e1de9b6b0b2 is wrong and the whole series needs to be fixed by not creating $this->data->db.

jking commented

2017-02-20 17:07:56 -05:00

Author

Owner

This should be fixed by commit 7785eb072b, but there may still be bugs; test coverage needs to improve before this issue can be closed.

This should be fixed by commit 7785eb072ba927aa1ccc8d63425fef3b479e4cc2, but there may still be bugs; test coverage needs to improve before this issue can be closed.

jking commented

2017-02-25 13:01:12 -05:00

Author

Owner

Confirmed fixed by commit 1834cb9963.

Confirmed fixed by commit 1834cb9963262cb164ff3f9d252fdf12d7dcfa51.