Use PSR-7 #53

New issue

Closed

opened 2017-05-27 08:14:45 -04:00 by jking · 2 comments

jking commented

2017-05-27 08:14:45 -04:00

Owner

PHP-FIG published PSR-7, a model for representing HTTP requests and responses in a consistent and coherent way. Currently Arsse has its own ad hoc lightweight representation, but switching to a tested PSR-7 implementation (such as that provided by Guzzle) would probably reduce the potential for bugs.

PHP-FIG published [PSR-7](http://www.php-fig.org/psr/psr-7/), a model for representing HTTP requests and responses in a consistent and coherent way. Currently Arsse has its own ad hoc lightweight representation, but switching to a tested PSR-7 implementation (such as that provided by [Guzzle](https://github.com/guzzle/psr7)) would probably reduce the potential for bugs.

jking referenced this issue from a commit

2018-01-04 23:09:10 -05:00

Replace Response objects with PSR-7 response messages; improves #53 While the test suite passes, this commit yields a broken server: replacing ad hoc request objectss with PSR-7 ones is still required, as is emission of PSR-7 responses. Both will come in subsequent commits, with tests Diactoros was chosen specifically because it includes facilities for emitting responses, something which is awkward to test. The end of this refactoring should see both the Response and Request classes disappear, and the general REST class fully covered (as well as any speculative additions to AbstractHanlder).

jking referenced this issue from a commit

2018-01-04 23:09:11 -05:00

Replace Resquest objects with PSR-7 request messages; improves #53

jking modified the milestone from Future to 0.3.0

2018-01-06 11:40:37 -05:00

jking commented

2018-01-06 11:44:11 -05:00

Author

Owner

For the time being, we will be using Diactoros for PSR-7 functionality. It provides significantly more compelling features than Guzzle.

For the time being, we will be using [Diactoros](https://zendframework.github.io/zend-diactoros/overview/) for PSR-7 functionality. It provides significantly more compelling features than Guzzle.

jking referenced this issue from a commit

2018-01-06 12:02:53 -05:00

Initial rewrite of REST class; needs more testing, but should be functional - improves #53 - improves #66

jking referenced this issue from a commit

2018-01-07 12:59:14 -05:00

Tests and fixes for REST class; fixes #53; improves #66

jking closed this issue

2018-01-07 12:59:14 -05:00

jking commented

2018-01-09 12:31:17 -05:00

Author

Owner