MensBeam
/
Catcher
3
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity
Labels Milestones
New Issue

Change :: to -> for instanced methods in PlainTextHandler #5

Closed
opened 1 year ago by dustinwilson · 1 comments
dustinwilson commented 1 year ago
Owner

Currently PlainTextHandler uses :: as in Catcher::setOption. This is the normal way to express things in PHP land, but it's confusing as that's how in actual code you call static methods. Should change that to ->instead for instanced methods to make it obvious.

Currently PlainTextHandler uses `::` as in `Catcher::setOption`. This is the normal way to express things in PHP land, but it's confusing as that's how in actual code you call static methods. Should change that to `->`instead for instanced methods to make it obvious.
dustinwilson added the
enhancement
 label 1 year ago
dustinwilson commented 1 year ago
Poster
Owner

Fixed by 5d8e77e89a.

Fixed by 5d8e77e89a.
dustinwilson closed this issue 1 year ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
2.1.0
main
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes