MensBeam/Framework
3
0
Fork 0
Code Issues Pull requests Projects Releases 4 Wiki Activity

Fixed method name caching bug in magic properties

Browse source
This commit is contained in:
Dustin Wilson 2021-10-20 22:45:28 -05:00
parent d2999f53be
commit 122eeb4d3e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/MagicProperties.php
View file

@ -50,17 +50,17 @@ trait MagicProperties {
// PHP. Properties in PHP 8 are sensitive, so let's use reflection to check
// against the actual name to get a case sensitive match like methods should be!
private function getMagicPropertyMethodName(string $name, bool $get = true): ?string {
static $protectedMethodsList = null;
static $protectedMethodsList = [];
$methodName = "__" . (($get) ? 'get' : 'set') . "_{$name}";
if (method_exists($this, $methodName)) {
if ($protectedMethodsList === null) {
if (!isset($protectedMethodsList[$this::class])) {
$reflector = new \ReflectionClass($this);
// Magic property methods are protected
$protectedMethodsList = $reflector->getMethods(\ReflectionMethod::IS_PROTECTED);
$protectedMethodsList[$this::class] = $reflector->getMethods(\ReflectionMethod::IS_PROTECTED);
}
foreach ($protectedMethodsList as $method) {
foreach ($protectedMethodsList[$this::class] as $method) {
if ($method->name === $methodName) {
return $methodName;
}