MensBeam/HTML-Parser
3
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixed yet another xmlns issue...

Browse source
This commit is contained in:
Dustin Wilson 2021-11-21 19:55:09 -06:00
parent cb57dd8e11
commit afaf10d602
3 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/Parser/AttributeSetter.php
View file

@ -42,6 +42,14 @@ trait AttributeSetter {
$element->setAttributeNS($namespaceURI, $qualifiedName, $value);
$this->mangledAttributes = true;
}
} elseif ($namespaceURI === null && $qualifiedName === 'xmlns') {
// There are even more bugs with xmlns attributes. Xmlns attributes on html
// elements are parsed in the null namespace per the specification. PHP still
// goes a bit screwy when trying to access them afterwards. Attempt to work
// around that.
$a = $element->ownerDocument->createAttribute('xmlns');
$a->value = $value;
$element->setAttributeNode($a);
} else {
try {
$element->setAttribute($qualifiedName, $value);

4
tests/cases/TestTreeConstructor.php
View file

@ -15,7 +15,7 @@ use MensBeam\HTML\Parser\TemplateInsertionModesStack;
use MensBeam\HTML\Parser\Tokenizer;
use MensBeam\HTML\Parser\TreeConstructor;
/**
/**
* @covers \MensBeam\HTML\Parser\Data
* @covers \MensBeam\HTML\Parser\Tokenizer
* @covers \MensBeam\HTML\Parser\TreeConstructor
@ -128,6 +128,8 @@ class TestTreeConstructor extends \PHPUnit\Framework\TestCase {
for ($a = 0; $a < sizeof($exp); $a++) {
if (preg_match('/^\|\s+xmlns xmlns=/', $exp[$a])) {
$exp[$a] = preg_replace('/^\|(\s+)xmlns xmlns=/', "|$1xmlns=", $exp[$a]);
} elseif (preg_match('/^\|\s+xmlns=/', $exp[$a])) {
$this->markTestSkipped();
}
}
}

10
tests/cases/tree-construction/mensbeam03.dat
View file

@ -143,3 +143,13 @@ table
| <tbody>
| <tr>
| "X"
#data
<!DOCTYPE html><html xmlns="ook">
#errors
#document
| <!DOCTYPE html>
| <html>
| xmlns="ook"
| <head>
| <body>