Commit graph

103 commits

Author SHA1 Message Date
32f4cca039 Type hints for tree builder properties 2021-02-14 23:39:17 -05:00
5f1f02b552 Skip tests requiring unimplemented logic 2021-02-14 21:57:44 -05:00
8e7a0f6284 Clean up foreign content case normalization 2021-02-14 20:28:37 -05:00
6798c128e4 Correct unknown DOCTYPE checking 2021-02-14 19:33:23 -05:00
29fd5e2ccb Fix invalid property accesses 2021-02-14 18:50:24 -05:00
1dc3d9c23e Emit whitespace-only character tokens
This makes tree building simpler in certain circumstances
2021-02-14 18:31:16 -05:00
9c3764da65 Stub of adoption agency 2021-02-14 15:44:05 -05:00
a8ff431370 Corrective pass over exising insertion modes 2021-02-14 15:09:00 -05:00
f8b9cf2c2b Avoid implicit looping and switching
The while loop has been replaced with gotos where appropriate, and
switching has been replaced with a series of if-blocks in line with the
same logic in the tokenizer.
2021-02-13 14:37:04 -05:00
e3a271f06b Fix first failure in tree builder 2021-02-13 10:29:07 -05:00
1fa2f701cb Update section of tokenization in spec comments 2021-02-13 10:14:26 -05:00
4e5fd35775 Fix a few tree tests 2021-02-12 23:26:57 -05:00
ad0a8ae27a Replace Content-Type parser with proper version 2020-09-25 12:34:53 -04:00
4e79f378a8 Fix bug uncovered by new tests 2020-09-17 09:12:14 -04:00
f72809d621 Relax dependence on ctype 2019-12-24 09:38:42 -05:00
1f3c33ad9e Better coverage of BOM-based detection 2019-12-23 09:13:08 -05:00
21c9377b3a Docblock for BOM detection 2019-12-23 08:43:15 -05:00
06e43504d0 Tweaks 2019-12-22 23:38:15 -05:00
164e5ff1e8 Add standard charset detection tests
- Various new tests needed for full coverage, noted in comment
- Byte Order Mark detection methopd added
- Japanese encodings nt yet supported, so tests marked incomplete
- Tests requiring scripting suppressed
2019-12-22 22:51:18 -05:00
a7e1083681 Prototype character encoding detection 2019-12-22 13:36:59 -05:00
49f31015ac Start on character encoding detection 2019-12-21 14:53:51 -05:00
00bf9974c5 Fix up most error reporting positions 2019-12-19 22:28:11 -05:00
58a1177888 Address errors and omissions in error emission
One test still fails, though it is arguably immaterial. This does not
account for line and column number, which are known to be mostly
off by one.
2019-12-19 15:13:20 -05:00
ec199f4f11 Report input stream errors 2019-12-18 21:10:18 -05:00
9560358021 Character consumption cleanup
- Newline normalization now done on-the-fly
- Consequently, original input string is used as-is
- Byte order mark is not supposed to be skipped
- Use more straightforward method of tracking column position
- Simplify backtracking when spanning
- Genericize character interpretation: this will be expanded to emit
illegal-character parse errors when appropriate
2019-12-18 18:03:47 -05:00
1ed679c50d Pass through surrogate characters
This fixes the last four failing tests
2019-12-18 15:15:02 -05:00
5a12fa8ad7 Tidying 2019-12-17 17:08:19 -05:00
e8b3c76046 Fix most failures
Also removed assertions
2019-12-17 13:47:53 -05:00
59456b078f Fix consuming of overlong entitiy 2019-12-17 12:32:29 -05:00
e8f35e92fb Character reference fixes
One test in the "entities.test" file is till failing
2019-12-16 23:41:44 -05:00
b9b892e6a6 Remove obsolete character reference consumer 2019-12-16 22:56:47 -05:00
19fb541806 New from-scratch character reference consumer 2019-12-16 22:39:16 -05:00
67c7f382e2 Prep for character references
- Add missing state constants
- Break all existing deviations for character refs
- Add assertions before use of $attribute
- Also fix DOCTYPE state
2019-12-15 22:20:20 -05:00
d4a7280405 Renumber states to match specification sections 2019-12-15 21:22:45 -05:00
4759f94771 Trim whitespace 2019-12-15 21:14:55 -05:00
cf41984e88 Fix comment end state 2019-12-15 21:13:10 -05:00
43f380c1f9 Fix EOF and end tags
- End tags now emit errors if they have attributes
- End tags now emit errors if they are self-closing
- The last character before EOF is now correctly reconsumed

Also changed the tokenizer debug log to be zero-cost
2019-12-15 19:45:59 -05:00
d08438052a Baseline pass over tokenizer
- Implemented missing states (except entity and char ref states)
- Re-copied and reformated most text from the specification
- Emitted parse errors per spec (except invalid characters)
- Properly handled null characters
- Passed through invalid characters (these do not yet emit errors)
- Added assertions before manipulation of tokens and temporary buffers
- Removed problematic optimizations
- Reoved explicit continue statements
- Allowed end tags to have attributes
- Simplified duplicate attribute detection
- Corrected DOCTYPE properties not being "missing"
- Skipped BOM in encoding-neutral way

I may have introduced regressions, and the assertions are mostly serving to
mask undefined-variable errors rather than helping to fix them, but at least
warnings and notices are not being spammed this way.

Work still need to be done in emitting errors for invalid characters (and
invalid character sequences), also well as in consuming character
references and entities correctly, not to mention general debugging.
2019-12-15 17:47:45 -05:00
4e4aee2edd Update intl dependency 2019-12-13 12:13:44 -05:00
a0c3883363 Another infinite loop in Tokenizer caused by Data 2019-12-12 22:45:13 -06:00
49820afe7d Fix broken assertion 2019-12-12 21:50:44 -05:00
362bb00158 Fix accidental exception instantiation loop 2019-12-12 21:06:05 -05:00
3c7a76bce1 Retrofit tree builder for new error emitter
Also fixed a number of undefined variable errors and erroneous
non-root namespace references
2019-12-12 18:10:01 -05:00
6b42f08fbc Change some if-the-exception blocks to assertions
This has only been done some parts of the code that are internal
to the parser at large.
2019-12-12 17:35:24 -05:00
bb2a7b5a95 Rewrite how parse errors are handled
Everything which can emit a parse error should have the error handler
and data stream as properties and use the ParseErrorEmitter trait to
avoid complicating the task of actually producing an error.

Normally the Parser would be expected to set the error handler before it
begins (this commit does not do this) and unset it after it's done.
Alternatively, the entire means of reporting errors can now be easily
replaced.
2019-12-12 15:23:15 -05:00
8644b6c757 Explicitly index state names and error messages 2019-12-12 10:11:36 -05:00
51ac79128b Multiple minor fixes 2019-12-11 23:28:32 -05:00
30003fce1f Fixed various issues with Data::consumeCharacterReference 2019-12-11 21:38:04 -06:00
5fb58054ff Don't read past the end of $args 2019-12-11 20:49:24 -05:00
ab507a177f Data::consumeCharacterReference checked for false instead of empty string 2019-12-11 19:44:45 -06:00