MensBeam/HTTP-Client
3
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

retry_callback can't modify some configuration options #1

New issue
Open
opened 2025-04-01 13:30:49 -04:00 by dustinwilson · 0 comments
dustinwilson commented 2025-04-01 13:30:49 -04:00
Owner
Copy link

When using retry_callback the intention is to allow overwriting of the options array so options inside may be changed for subsequent requests. Not all options are overwritable, and none are rechecked for validity before being passed to the retry request. Probably need to make sure the class is reinstantiated on each retry, not just on the initial. That way the options are validity checked.

When using retry_callback the intention is to allow overwriting of the options array so options inside may be changed for subsequent requests. Not all options are overwritable, and none are rechecked for validity before being passed to the retry request. Probably need to make sure the class is reinstantiated on each retry, not just on the initial. That way the options are validity checked.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
2.0
1.5
2.1.1
2.1.0
2.0.0
1.5.0
1.0.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dustinwilson
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: MensBeam/HTTP-Client#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?