From 035c960a0b21068772f4f29f7630f4d187c73514 Mon Sep 17 00:00:00 2001 From: "J. King" Date: Thu, 10 Sep 2020 08:52:03 -0400 Subject: [PATCH] Inprove message for skipped URL test --- tests/cases/Util/Url/UrlTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/cases/Util/Url/UrlTest.php b/tests/cases/Util/Url/UrlTest.php index 59a4bb4..170e9c3 100644 --- a/tests/cases/Util/Url/UrlTest.php +++ b/tests/cases/Util/Url/UrlTest.php @@ -11,7 +11,7 @@ use MensBeam\Lax\Url; /** @covers MensBeam\Lax\Url */ class UrlTest extends Psr7TestCase { private const INCOMPLETE_STD_INPUT = [ - "http://\u{1F}!\"$&'()*+,-.;=_`{|}~/", // PHP's IDNA implementation fails here + "http://\u{1F}!\"$&'()*+,-.;=_`{|}~/" => "PHP's IDNA implementation fails here", ]; protected function createUri($uri = '') { @@ -20,8 +20,8 @@ class UrlTest extends Psr7TestCase { /** @dataProvider provideStandardParsingTests */ public function testParsePerWhatwgRules(string $input, string $base, ?string $exp): void { - if (in_array($input, self::INCOMPLETE_STD_INPUT)) { - $this->markTestIncomplete(); + if (isset(self::INCOMPLETE_STD_INPUT[$input])) { + $this->markTestIncomplete(self::INCOMPLETE_STD_INPUT[$input]); } $act = Url::fromString($input, $base); //var_export($act);