Commit graph

584 commits

Author SHA1 Message Date
22941f5ad1 Fix session tests
PostgreSQL now passes all tests. Connection and permission errors still
need to be accounted
for before the implementation is complete.
2018-12-05 12:07:45 -05:00
15301cd7dc Fix cleanup tests in PostgreSQL 2018-12-05 11:05:01 -05:00
258be1d54e Fix most PostgreSQL test failures
Reasons for failures included an unhandled error code, erroneous sorting
assumptions, and a broken computation of the next insert ID in tests

Five failures remain.
2018-12-05 09:05:43 -05:00
8fc31cfc40 Rewrite various queries to work in PostgreSQL
This involved changes to the driver interface as well as the database
schemata. The most significantly altered queries were for article
selection and marking, which relied upon unusual features of SQLite.
Overall query efficiency should not be adversely affected (it may have
even imprved) in the common case, while very rare cases (not presently
triggered by any REST handlers) require more queries.

One notable benefit of these changes is that functions which query
articles can now have complete control over which columns are returned.
This has not, however, been implemented yet: symbolic column groups are
still used for now.

Note that PostgreSQL still fails many tests, but the test suite runs to
completion. Note also that one line of the Database class is not
covered; later changes will eventually make it easier to cover the line
in question.
2018-12-04 20:41:21 -05:00
5c5a5a4886 Appease PostgreSQL's max() aggregate 2018-11-29 14:36:34 -05:00
527ecee393 Code coverage fixes 2018-11-29 13:56:15 -05:00
4a1c23ba45 Munge PostgreSQL queries instead of adding explicit casts
PDO does not adequately inform PostgreSQL of a parameter's type, so type
casts are required. Rather than adding these to each query manually, the
queries are instead processed to add type hints automatically.

Unfortunately the queries are processed rather naively; question-mark
characters in string constants, identifiers, regex patterns, or geometry
operators will break things spectacularly.
2018-11-29 13:45:37 -05:00
4c8d8f1a52 Provide PostgreSQL with an empty-set query for IN() clauses
Also satisfy PostgreSQL with some explicit casts
2018-11-28 17:18:33 -05:00
e68fcc0afa Manipulate only those sequences in the current PostgreSQL schema 2018-11-28 17:16:03 -05:00
4a2efd9987 Correct the state of PostgreSQL serial sequence during tests 2018-11-28 16:24:12 -05:00
dd4f22e04e Avoid use of reserved SQL word "user" 2018-11-28 14:21:36 -05:00
0f7baf4b51 Base MySQL schema
Note the columns "key" and "read" must be quoted in addition to "user".
2018-11-28 14:00:36 -05:00
10b228224d Correct PostgreSQL data format and other tweaks 2018-11-28 12:12:49 -05:00
8dfedd30ef Test PostgreSQL schema upgrade
This was in fact buggy due to the schema version check causing an error
2018-11-28 10:46:23 -05:00
d0db784b22 PostgreSQL schema tweak 2018-11-27 17:50:38 -05:00
93af381436 Test setting of schema name 2018-11-27 17:39:39 -05:00
1414f8979c Fix savepoint handling and locking in PostgreSQL driver 2018-11-27 17:16:00 -05:00
8a49202036 Use common cleanup code for all database-related tests 2018-11-27 14:26:33 -05:00
925560d4ba Cleanup 2018-11-25 00:06:20 -05:00
a75fad53ca Adapt the rest of the test series 2018-11-25 00:03:56 -05:00
dccd4caede Convert one database function test series (articles) to a common harness
Also revert the dropping of tables in the schema files. This was for the
convenience of tests, but the risk of data loss is too great
2018-11-24 23:18:17 -05:00
36c5984c47 Add drop statements to database schemata to simplify testing 2018-11-23 12:53:56 -05:00
7340d65c0e Make data clearing in tests static 2018-11-23 10:01:17 -05:00
39110858b7 Move database function test series as first step in re-organization 2018-11-23 09:29:06 -05:00
8c20411359 Align statement tests with other database driver tests 2018-11-22 23:18:20 -05:00
f22e53fdc9 Align result tests with driver tests 2018-11-22 19:55:54 -05:00
aa1b65b5d4 Take a different tack on shared database tests
Tests for different drivers will have their own files, but all derive
from a common prototype test series where applicable, similar to the
existing arrangement for database function tests. However, the prototype
will reside with other test cases rather than in the library path. The
database function test series will hopefully be moved as well in time.
2018-11-22 13:55:57 -05:00
8103d37bc7 Dev dependency update 2018-11-22 13:36:25 -05:00
736a8c9d0c Improved timeout handling for both SQlite and PostgreSQL 2018-11-22 13:30:13 -05:00
4e444fd86c Generic database interface creation in tests 2018-11-21 13:06:01 -05:00
c0c4810662 Nominally complete PostgreSQL driver
Connection error handling as well as uprade error handling still need
to be implemented.
2018-11-21 11:06:12 -05:00
84b4cb7465 Enable PostgreSQL statement testing
Tests involving binary data are skipped for now
2018-11-20 16:32:18 -05:00
d52af6db5a PostgreSQL fixes
Errors were not correctly throwing exceptions

For the sake of SQLite compatibility booleans should be bound as
integers in PDO
2018-11-20 15:48:03 -05:00
e2b6cb8360 Remove PicoFeed-related FIXMEs
PicoFeed will never be fixed, so they are not helpful
2018-11-20 15:46:22 -05:00
b5733b070c Clean up statement tests
PostgreSQL tests are suppressed for now, but most pass.
2018-11-20 15:45:20 -05:00
e30d82fbaa Correct signature 2018-11-16 21:35:05 -05:00
976672de5b Test cleanup 2018-11-16 21:32:27 -05:00
edfae438fa Refine pg connection strings 2018-11-16 21:20:54 -05:00
796315c00c Basic stub of PDO-base PostgreSQL driver 2018-11-10 00:02:38 -05:00
c63d24e125 Version bump 2018-11-09 23:57:33 -05:00
471dad0645 Fix PDO driver initialization 2018-11-09 20:27:05 -05:00
c4ca9149a1 Move Statement tests 2018-11-09 15:01:46 -05:00
7e11019e83 Consolidate statement tests 2018-11-09 14:58:10 -05:00
ea6b4c951e Skip Result tests when necessary 2018-11-09 14:56:30 -05:00
a3dbb08da9 Remove obsolete test code 2018-11-08 16:29:46 -05:00
30d6f6db37 Consolidate Db result test series into single file 2018-11-08 14:50:58 -05:00
ffea7e804a Sync Composer locks 2018-11-07 13:11:27 -05:00
467cc66cc8 Update changelog 2018-11-07 13:06:33 -05:00
3b3b810f10 Replicate some unspecified NCNv1 behaviour, and document the rest
See #139 for list

Closes #139
Closes #140
Closes #141
2018-11-07 13:01:46 -05:00
1dcbb56077 Changelog and documentation updates 2018-11-07 10:24:35 -05:00