Browse Source

Fix 405 response of NCN version lister

microsub
J. King 7 years ago
parent
commit
d1e4c6eed3
  1. 2
      lib/REST/NextCloudNews/Versions.php
  2. 2
      tests/REST/NextCloudNews/TestNCNVersionDiscovery.php

2
lib/REST/NextCloudNews/Versions.php

@ -11,7 +11,7 @@ class Versions implements \JKingWeb\Arsse\REST\Handler {
public function dispatch(\JKingWeb\Arsse\REST\Request $req): Response { public function dispatch(\JKingWeb\Arsse\REST\Request $req): Response {
// if a method other than GET was used, this is an error // if a method other than GET was used, this is an error
if ($req->method != "GET") { if ($req->method != "GET") {
return new Response(405); return new Response(405, "", "", ["Allow: GET"]);
} }
if (preg_match("<^/?$>", $req->path)) { if (preg_match("<^/?$>", $req->path)) {
// if the request path is an empty string or just a slash, return the supported versions // if the request path is an empty string or just a slash, return the supported versions

2
tests/REST/NextCloudNews/TestNCNVersionDiscovery.php

@ -26,7 +26,7 @@ class TestNCNVersionDiscovery extends Test\AbstractTest {
} }
public function testUseIncorrectMethod() { public function testUseIncorrectMethod() {
$exp = new Response(405); $exp = new Response(405, "", "", ["Allow: GET"]);
$h = new REST\NextCloudNews\Versions(); $h = new REST\NextCloudNews\Versions();
$req = new Request("POST", "/"); $req = new Request("POST", "/");
$res = $h->dispatch($req); $res = $h->dispatch($req);

Loading…
Cancel
Save