Commit graph

571 commits

Author SHA1 Message Date
3da773eef6 Grammar tweak 2018-12-22 09:58:56 -05:00
cefc9e5b4d Don't use Canada mirror in links to PHP manual 2018-12-21 18:02:03 -05:00
7191dd5778 Documentation update 2018-12-21 18:00:35 -05:00
206cca35a9 Test tweaks 2018-12-21 17:51:49 -05:00
5a133b795a Correctly munge MySQL queries 2018-12-21 17:37:22 -05:00
b4de56a64e Work around MySQL silliness with same-table foreign keys 2018-12-21 17:02:34 -05:00
f0d30c2eee Make munging of queries a generic feature 2018-12-21 12:35:10 -05:00
24df564045 Mostly successful MySQL database function tests
Two failures remain, at least one requiring query munging.
2018-12-21 10:14:26 -05:00
de07352fd0 Syntactic adjustments for MySQL
- "key", "read", and "rename" are reserved words
- CTEs in INSERTs must precede SELECT
- Empty sets are represented only by explicit null
2018-12-20 21:23:06 -05:00
393b4e95ad Adjustments for MySQL 8
The prototype had been tested against MariaDB
2018-12-20 20:50:56 -05:00
4ef36643a4 Proof-of-concept PDO MySQL driver
- Configuration options were added
- Non-transactional locking was added to the savepoint handlers
- Tests were adjusted for MySQL's reserved words
2018-12-20 18:06:28 -05:00
316ba941a2 Hopefully complete MySQL schema 2018-12-15 11:09:46 -05:00
86c16d3cb3 Merge branch 'master' into mysql 2018-12-15 09:22:47 -05:00
8d9d249b88 Merge branch 'pg' 2018-12-14 09:28:19 -05:00
50f92625ef Use PosgreSQL's existing general Unicode collation
All collations appear to be case-insensitive
2018-12-14 09:18:56 -05:00
17052d3232 Update PostgreSQL-related documentation 2018-12-13 20:08:35 -05:00
29e7c1f154 Fix coverage 2018-12-13 19:56:07 -05:00
2bebdd44cf Implementation of native PostgreSQL interface
Changes to the Database class were required to avoid outputting booleans
2018-12-13 19:47:51 -05:00
b52dadf345 Make existing PostgreSQL tests explicitly PDO tests 2018-12-12 12:42:40 -05:00
161f5f08f6 Proactively support SQLite 3.25 2018-12-12 12:21:28 -05:00
28f803dd28 Handle PostgreSQL connection errors 2018-12-12 11:15:07 -05:00
0f48ce6f37 Use a Unicode collation for SQLite 2018-12-11 14:14:32 -05:00
a8e6487001 Draft documentation 2018-12-10 19:13:48 -05:00
73729a6be8 Simplify database cleanup between tests 2018-12-10 13:17:04 -05:00
8dbf237626 Group PostgreSQL tests as slow 2018-12-10 12:39:09 -05:00
35d46d2913 Use persistent connections with PostgreSQL 2018-12-10 12:28:43 -05:00
913cf71620 Fix incorrect annotations 2018-12-07 20:36:20 -05:00
f6966659a9 Use smarter coverage executer; properly suppress stderr during CLI tests 2018-12-07 20:25:48 -05:00
d9629be662 Use smarter coverage executer; properly suppress stderr during CLI tests 2018-12-07 20:03:04 -05:00
0513b606c2 Merge master 2018-12-07 19:21:44 -05:00
b9272ea2eb Fix test failures in PHP 7.1 2018-12-07 15:34:47 -05:00
f7b9a2a6cf Fixes for PHPUnit 7 2018-12-07 13:49:49 -05:00
089f666de6 Fix PDO insert ID errors in PHP 7.1 2018-12-06 17:46:00 -05:00
cf896121b2 Style fixes 2018-12-05 17:28:11 -05:00
f2245861e3 Restore complete Database coverage
Also suppress PostgreSQL database function tests from normal coverage,
and add a "coverage:full" task to run them if needed.
2018-12-05 17:07:47 -05:00
51755a2ce6 Retire article field groups 2018-12-05 16:55:14 -05:00
0129965bbd Cover some missed code 2018-12-05 12:54:19 -05:00
22941f5ad1 Fix session tests
PostgreSQL now passes all tests. Connection and permission errors still
need to be accounted
for before the implementation is complete.
2018-12-05 12:07:45 -05:00
15301cd7dc Fix cleanup tests in PostgreSQL 2018-12-05 11:05:01 -05:00
258be1d54e Fix most PostgreSQL test failures
Reasons for failures included an unhandled error code, erroneous sorting
assumptions, and a broken computation of the next insert ID in tests

Five failures remain.
2018-12-05 09:05:43 -05:00
8fc31cfc40 Rewrite various queries to work in PostgreSQL
This involved changes to the driver interface as well as the database
schemata. The most significantly altered queries were for article
selection and marking, which relied upon unusual features of SQLite.
Overall query efficiency should not be adversely affected (it may have
even imprved) in the common case, while very rare cases (not presently
triggered by any REST handlers) require more queries.

One notable benefit of these changes is that functions which query
articles can now have complete control over which columns are returned.
This has not, however, been implemented yet: symbolic column groups are
still used for now.

Note that PostgreSQL still fails many tests, but the test suite runs to
completion. Note also that one line of the Database class is not
covered; later changes will eventually make it easier to cover the line
in question.
2018-12-04 20:41:21 -05:00
5c5a5a4886 Appease PostgreSQL's max() aggregate 2018-11-29 14:36:34 -05:00
527ecee393 Code coverage fixes 2018-11-29 13:56:15 -05:00
4a1c23ba45 Munge PostgreSQL queries instead of adding explicit casts
PDO does not adequately inform PostgreSQL of a parameter's type, so type
casts are required. Rather than adding these to each query manually, the
queries are instead processed to add type hints automatically.

Unfortunately the queries are processed rather naively; question-mark
characters in string constants, identifiers, regex patterns, or geometry
operators will break things spectacularly.
2018-11-29 13:45:37 -05:00
4c8d8f1a52 Provide PostgreSQL with an empty-set query for IN() clauses
Also satisfy PostgreSQL with some explicit casts
2018-11-28 17:18:33 -05:00
e68fcc0afa Manipulate only those sequences in the current PostgreSQL schema 2018-11-28 17:16:03 -05:00
4a2efd9987 Correct the state of PostgreSQL serial sequence during tests 2018-11-28 16:24:12 -05:00
dd4f22e04e Avoid use of reserved SQL word "user" 2018-11-28 14:21:36 -05:00
0f7baf4b51 Base MySQL schema
Note the columns "key" and "read" must be quoted in addition to "user".
2018-11-28 14:00:36 -05:00
10b228224d Correct PostgreSQL data format and other tweaks 2018-11-28 12:12:49 -05:00